simplesamlphp / simplesamlphp/saml2
Convert \SAML2\Configuration\IdentityProvider to interface
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 306
- Forks
- 138
- PR merge metrics
- No merged PRs in 30d
Description
I'd like to integrate this library into my application. However, \SAML2\Configuration\IdentityProvider and \SAML2\Configuration\ServiceProvider are classes.
Is there any interest in converting them to pure interfaces such that one can implement completely custom service/identity provider configuration classes (not based on arrays)? If so, should I submit a pull-request and rename the existing class to QueryableIdentityProvider?
Intent: We'd like to use \SAML2\Assertion\ProcessorBuilder to validate our assertions.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the existing \SAML2\Configuration\IdentityProvider and \SAML2\Configuration\ServiceProvider classes, then trace how \SAML2\Assertion\ProcessorBuilder uses them. Clarify the interface contract and compatibility impact before changing the classes; done means custom non-array-based provider configurations can be used to validate assertions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100