simplesamlphp / simplesamlphp/saml2-module-spid

PHP 8.4: update to PHP 8.4's DOM Spec Compliance

Open
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

See: https://www.php.net/manual/en/class.dom-document.php and https://wiki.php.net/rfc/opt_in_dom_spec_compliance

New namespaced DOM-classes have been introduced in PHP 8.4 that are better in terms of performance and spec compliance.
This should be applied to all xml-libraries extending from this one.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the PHP 8.4 DOM documentation and the DOM spec compliance RFC first. Then identify all XML libraries extending this one and determine which classes require the namespaced DOM equivalents. Done means those libraries use the PHP 8.4-compliant DOM API without breaking existing behavior; run the repository's available test suite to verify compatibility.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.