color picker not hide when clicking on save button
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 4.5k
- Forks
- 292
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/simonwep/pickr/blob/afd6b18258342a5dfb66843ab3891b6900eeb7b7/src/js/pickr.js#L398
Hi, bro. please make sure that '!this.applyColor()' is necesary condition.
becaues it always return 'this' instance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/js/pickr.js around line 398 and reproduce the issue by clicking the save button while the color picker is open. Trace the save-button condition involving !this.applyColor(), then verify that clicking save hides the picker as expected without breaking color application behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100