simonw / simonw/sqlite-utils

delete_where() fails to commit in 3.x

Open
#815 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
2.2k
Forks
172
Avg merge
9m
Merged PRs (30d)
1

Description

We fixed this in 4.0 but it's actually a bug in 3.x that I think deserves a dot-release fix.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating delete_where() in the 3.x code and compare its behavior with the 4.0 implementation, where the issue says this was fixed. Reproduce the missing commit behavior against SQLite and identify the existing tests covering delete_where(); done means the 3.x fix is covered by a regression test and commits as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, sqlite
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.