simonw / simonw/llm

Do we still need the "Ensure it can see the API key" branch?

Open
#993 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

refactor research
Dominant language
Python
Stars
12.5k
Forks
998
Avg merge
3d 13h
Merged PRs (30d)
10

Description

Here:

https://github.com/simonw/llm/blob/7f49cc254b1fdc2eb1555a03627d31bf38337926/llm/cli.py#L905-L910

That's from before I refactored how keys work in 6c6b100f3ee16983e9a3d9ec09aecb2b91210ed7

Do we still need that branch?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in llm/cli.py at lines 905-910 and compare that branch with the key-handling refactor in commit 6c6b100f3ee16983e9a3d9ec09aecb2b91210ed7. Determine whether the branch is still reachable or necessary after the refactor. Done means retaining it with a clear justification or removing it while preserving the expected CLI behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.