500 error on m2m facet detection
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 11.5k
- Forks
- 904
- Avg merge
- 4d 17h
- Merged PRs (30d)
- 18
Description
This may help debug:
diff --git a/datasette/facets.py b/datasette/facets.py
index 76d73e5..07a4034 100644
--- a/datasette/facets.py
+++ b/datasette/facets.py
@@ -499,11 +499,14 @@ class ManyToManyFacet(Facet):
"outgoing"
]
if len(other_table_outgoing_foreign_keys) == 2:
- destination_table = [
- t
- for t in other_table_outgoing_foreign_keys
- if t["other_table"] != self.table
- ][0]["other_table"]
+ try:
+ destination_table = [
+ t
+ for t in other_table_outgoing_foreign_keys
+ if t["other_table"] != self.table
+ ][0]["other_table"]
+ except IndexError:
+ import pdb; pdb.pm()
# Only suggest if it's not selected already
if ("_facet_m2m", destination_table) in args:
continue
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in datasette/facets.py at ManyToManyFacet and inspect the outgoing foreign-key handling around the supplied temporary pdb breakpoint. Reproduce the m2m facet scenario that raises the 500 error, then verify that facet detection completes without that failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100