simonw / simonw/datasette

Applied facet did not result in an "x" icon to dismiss it

Open
#2,011 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug faceting
Dominant language
Python
Stars
11.5k
Forks
903
Avg merge
4d 17h
Merged PRs (30d)
18

Description

CleanShot 2023-01-31 at 09 55 56@2x

That's against this data https://data.sfgov.org/City-Management-and-Ethics/Supplier-Contracts/cqi5-hm2d imported using https://datasette.io/plugins/datasette-socrata

It's for Contract Type of Non-Purchasing Contract (Rents, etc.) - so possible that some of the spaces or punctuation in either the name of the value tripped up the code that decides if the X icon should be displayed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the facet behavior using the linked Supplier Contracts dataset imported with datasette-socrata, focusing on the Contract Type value "Non-Purchasing Contract (Rents, etc.)". Trace how the applied facet is rendered and determine why its dismiss icon is missing; done means the applied facet displays an "x" icon for this value.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.