simonw / simonw/datasette-backup
Optional additional permission check
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Initially I'll use the database permission check - if the user has permission to access the database then they can download it.
But it would be good to be able to restrict permission further - especially since VACUUM INTO or .backup() on large files needs to be able to create a large temporary file.
Originally posted by @simonw in https://github.com/simonw/datasette-backup/issues/1#issuecomment-687671840
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing database permission check and the code paths for VACUUM INTO and .backup(). Determine how an optional, stricter permission can be configured for downloads, including backups that need a large temporary file. Done means the additional check is supported without removing the existing database-level permission behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sqlite
- Domain
- authorization, databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100