simonsobs / simonsobs/tilemaker

Size error with ACT DR4

Open
#1 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Tried to run the example with ACTPol_148_D5_PA1_S1_1way_I.fits from https://lambda.gsfc.nasa.gov/product/act/actpol_maps_get.html

I get an error in the shape of the arrays:

python fits.py create ACTPol_148_D5_PA1_S1_1way_I.fits ACTPol_148_D5_PA1_S1_1w
ay_I
Traceback (most recent call last):
  File "/home/zonca/p/software/tilemaker/example/fits.py", line 48, in <module>
    tree = LayerTree(number_of_layers=number_of_layers, image_pixel_size=tile_size, image=fits_image)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zonca/p/software/tilemaker/tilemaker/processing/fits_simple.py", line 422, in __init__
    layer.create_data_from_children()
  File "/home/zonca/p/software/tilemaker/tilemaker/processing/fits_simple.py", line 382, in create_data_from_children
    node.create_data_from_children()
  File "/home/zonca/p/software/tilemaker/tilemaker/processing/fits_simple.py", line 310, in create_data_from_children
    data_buffer[covered_region] = 0.25 * child_data
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^
ValueError: could not broadcast input array from shape (667,675) into shape (674,675)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the command shown in example/fits.py with the referenced ACT DR4 FITS file. Read tilemaker/processing/fits_simple.py around create_data_from_children and the failing assignment at line 310 to trace the array shapes. Done means the example processes this input without the broadcasting error, with the intended handling of the differing shapes confirmed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.