simonsobs / simonsobs/sotodlib
AxisManager.wrap axis_map arg vs. AxisManager._assignments format
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 19
- Forks
- 23
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 14
Description
The "axis_map" argument is perhaps too restrictive -- it should be extended to accept:
- a map that includes Nones, e.g.
[(0, 'dets'), (1, None)] - a simple list, e.g.
['dets', None].
It would also be nice if wrapping an AxisManager, and specifying axis_map=whatever-it's-going-to-be-after-wrapping-anyway, worked without complaint, too.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating AxisManager.wrap and inspecting the _assignments format and current axis_map validation. Verify how mapped axes containing None, simple lists, and an axis_map matching the wrapped AxisManager are handled; done means all three forms are accepted without complaint.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100