simonsobs / simonsobs/sotodlib
Bad subscans should not be called "valid"
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 19
- Forks
- 23
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 14
Description
Noticed this while trying to figure out why we were cutting detectors with the most "valid" subscans. Valid means good. "flag", "cut," or "bad" would mean bad.
If I'm somehow misunderstanding and these valid subscans are actually valid, then the docs need improvement.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect sotodlib/preprocess/processes.py around line 2623 and determine whether the subscans described there are genuinely valid or are flagged/cut as bad. If they are bad, update the misleading terminology; if they are valid, improve the documentation so the meaning is clear. No specific test is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-engineering
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100