Tagging should not be auto-lower-cased

Open
#1,455 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
data-engineering

Research direction

Start in sotodlib/site_pipeline/util.py at the linked line and trace how preprocess handles tags from nextline. Determine whether uppercase tags should remain usable or be propagated as lowercase, then verify that preprocessing accepts the HR10 tags without a local edit.

Written by the indexing model from the issue text.

Description

I was running a baby preprocess myself for the HR10 tagged observations for satp2. Turns out, I cannot actually run preprocess with any tags that have upper case letters because of this line (without just editing my local copy of sotodlib). Seems like it doesn't really serve a real purpose, so we should either take it out OR force all tags on nextline in the future to be propagated forward as lowercase.

https://github.com/simonsobs/sotodlib/blob/57f07f77299cac31ab0716e0f035c5cee79aafdc/sotodlib/site_pipeline/util.py#L405C24-L405C25

Dominant language
Python
Stars
19
Forks
23
Avg merge
1d 5h
Merged PRs (30d)
14

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from simonsobs/sotodlib

All issues in simonsobs/sotodlib

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.