simonsobs / simonsobs/sotodlib

load_and_preprocess does not apply some cuts if samps were restricted before it.

Open
#1,333 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

preprocess
Dominant language
Python
Stars
19
Forks
23
Avg merge
1d 5h
Merged PRs (30d)
14

Description

Found this issue when loading from the latest LAT preprocess_tod run. If there is a samps restriction in a preprocessing step before any one of det bias flags, trend flags, dark det flags, ptp flags, fp flags, or inv var flags, the cuts from these will not be applied when loading the data from an existing db since their select functions use has_all_cut. This requires all samps to be flagged. The update_full_aman function pads the samps axis to the original data shape so these are not marked as flagged when it is saved. This problem was introduced when load_and_preprocess was moved to collecting the selections first and then applying them in one go for improved loading speed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing load_and_preprocess, especially how selections using has_all_cut are collected and applied. Compare this with update_full_aman's padding of the samps axis, and reproduce the issue using an existing database from a LAT preprocess_tod run. Done means the det bias, trend, dark det, ptp, fp, and inv var cuts are applied even when samps was restricted earlier.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.