simonsobs / simonsobs/sotodlib

Handling of mapmaking module import/ use sub-modules ?

Open
#1,124 1 comment 1 reaction 2 assignees View on GitHub

@iparask is already working on this.

Since Feb 26, 2025.

  • #1175 by @chervias — closed without merging
mapmaking
Dominant language
Python
Stars
19
Forks
23
Avg merge
1d 5h
Merged PRs (30d)
14

Description

As suggested by @mhasself, we shouldn't use from .submodule import * in the __init__.py of mapmaking. Instead we could just import the handful of functions we need exposed or create some submodules (mapmaking.utils, mapmaking.demod_mapmaker and mapmaking.ml_mapmaker would be good I think) or a combination of both ideas. @iparask I will assign you and me for this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.