simonsobs / simonsobs/sotodlib

Enable flagging for tod stats

Open
#1,046 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement preprocess
Dominant language
Python
Stars
19
Forks
23
Avg merge
1d 5h
Merged PRs (30d)
14

Description

In #1028 we added summary statistics for tod, subscans, and PSDs, computed along the samps (or nusamps) axis. A boolean array or slice can be passed to flags.get_stats (link) to mask the signal array before computing the statistics. This was added to enable limiting the frequency range if the signal is a PSD.

Currently the mask is limited to 1d samps/nusamps, and cannot be used with subscan=True. It would be nice to

  • Allow mask to be a Ranges
  • Allow mask to be 2d / RangesMatrix
  • Combine the mask with subscan_flags to allow masking and subscan computation together.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in sotodlib/tod_ops/flags.py at get_stats, then trace how mask and subscan_flags are handled. Support Ranges, 2D masks or RangesMatrix, and their combination with subscan computation; done means all three requested masking cases work without changing existing statistics behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.