simonsobs / simonsobs/sorunlib

Focal Plane Temperature Setting?

Open
#91 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
0
Forks
0
Avg merge
17h 32m
Merged PRs (30d)
1

Description

This one might be more complicated because the agents will be different for the different telescopes. But I would currently love a single function that goes something like set_fpa_pid(temperature)

This is what I currently have for SATp1 (and I'm not totally sure data acquisition turns back on once this has run?)

setpoint=0.087 #Kelvin

LS = OCSClient('cryo-ls372-lsa21yc')

heater='sample'
ch=2
P_val=1000 #watts/Kelvin Started with 2500
I_val=1/40 #Hz Started with 1/20
update_time=1 #seconds
sample_heater_range=3.16e-3 #amps


# Stop data acq
LS.acq.stop()
LS.acq.wait()

#Stop the pid if it is already running
LS.custom_pid.stop()
LS.custom_pid.wait()

status, msg, session = LS.custom_pid.start(
    setpoint=setpoint, 
    heater=heater, 
    channel=ch, 
    P=P_val, 
    I=I_val, 
    update_time=update_time, 
    sample_heater_range=sample_heater_range, 
    test_mode=False
)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the OCSClient entry point and the custom_pid and acq calls shown in the issue, then compare how agents differ across telescopes. Confirm the expected acquisition behavior with maintainers before implementing a shared set_fpa_pid(temperature) interface; done means the function handles the supported telescope agents and its acquisition state is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.