simonsobs / simonsobs/sorunlib

Implement additional HWP commands

Open
#144 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
0
Forks
0
Avg merge
17h 32m
Merged PRs (30d)
1

Description

We need additional commands implemented in the hwp module. See this issue about the Supervisor Agent, specifically:

Also, do you think we should implement gripper.grip, gripper.ungrip, supervisor.enable_driver_board, and supervisor.disable_driver_board in sorunlib for the same reason?

There was also some discussion about changing hwp.set_freq() to hwp.spin() to make it more clearly an action that will cause the HWP to start up if it is stopped. The hwp module isn't really in use downstream yet, so now is the time to change it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the hwp module and reviewing its existing command implementations. Read the linked Supervisor Agent discussion for the expected gripper and driver-board commands, then review the discussion about renaming hwp.set_freq() to hwp.spin(). Done means the requested commands are implemented and the naming change is applied consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.