simonsobs / simonsobs/sodetlib

Fix not to modify bgmap by R0_thresh in bias step analysis

Open
#522 2 comments 0 reactions 2 assignees View on GitHub

@dpdutcher is already working on this.

Since Sep 16, 2026.

Dominant language
Python
Stars
5
Forks
0
Avg merge
3d 17h
Merged PRs (30d)
4

Description

bgmap of BiasStepAnalysis is modified to -1 when estimated TES resistance R0 exceeds R0_thresh = 30e-3 (Ohm).
I suggest to remove self.bgmap[m] = -1.

The cause of this failure is not the cross talk but the wrong approximation when the TES is near saturation and the loop gain ~ 1.
And we can fix the estimation later using tes_param_correction.py.
We don't need to mask the channel in the bgmap.
Keeping the original bgmap used for bias step analysis is more reasonable and useful for future analysis.
https://github.com/simonsobs/sodetlib/blob/8f9593b5204cb64a777901f557fe2f6c5e38bb13/sodetlib/operations/bias_steps.py#L670-L685
https://github.com/simonsobs/sodetlib/blob/8f9593b5204cb64a777901f557fe2f6c5e38bb13/sodetlib/operations/bias_steps.py#L736-L742

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.