simonsobs / simonsobs/socs

Lakeshore 372 Agent needs all available PID settings

Open
#910 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

agent: ls372 enhancement
Dominant language
Python
Stars
17
Forks
20
Avg merge
1h 22m
Merged PRs (30d)
2

Description

In an effort to improve our PIDing, we're looking at all the knobs we can turn.

I believe we need to add update time to the set_pid function or similar as I think that is a free parameter we can't currently modify.

Would also be good to know what the default value has been that is used with the current settings.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Lakeshore 372 Agent and its set_pid function, then inspect how the current PID settings and defaults are defined. Confirm which available PID parameters are exposed and how update time is handled. Done means the requested setting can be modified and the defaults used by the current configuration are identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.