Stale acu position data in hwp supervisor during `check_acu_ok_for_spinup()`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 17
- Forks
- 20
- Avg merge
- 1h 22m
- Merged PRs (30d)
- 2
Description
Related to this issue, satp3 had similar problem on Nov 29th 2024, by following schedule https://site.simonsobs.org/satp3/nextline/db/runs/2202
run.wait_until('2024-11-29T18:44:23.980000+00:00')
run.acu.move_to(az=180.0, el=40.0)
run.acu.move_to(az=180.0, el=48.0)
######## HWP spinning up ##########
run.hwp.set_freq(freq=2) # start HWP rotation
In this case, I think the safety was triggered due to the time lag of acu monitoring.
hwp spin up was called right after the telescope has moved from 40 to 48, and the hwp_supervisor checked the acu position that was updated slightly before, and it was lower than 48.
One of the solutions is to just add a time buffer in the schedule.
Originally posted by @ykyohei in https://github.com/simonsobs/socs/issues/788#issuecomment-2508417398
As discussed in that original thread, it seems most likely the HWP supervisor has an outdated cache of the ACU elevation. Can we force a hwp_state.acu.update() at the start of check_acu_ok_for_spinup()?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in socs/agents/hwp_supervisor/agent.py at check_acu_ok_for_spinup(), then review the linked discussion in issue #788 for the stale ACU-position scenario. Done means the spin-up safety check uses a freshly updated ACU position rather than an outdated cache, without requiring a schedule time buffer.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100