simonsobs / simonsobs/socs

JSONDecodeError in Radiometer agent

Open
#790 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs triage
Dominant language
Python
Stars
17
Forks
20
Avg merge
1h 22m
Merged PRs (30d)
2

Description

Radiometer agent crashed with the following JSONDecodeError:

2024-11-03T00:00:19+0000 acq:0 Status is now "done".
2024-11-03 00:00:19.691	
]
2024-11-03 00:00:19.691	
/opt/venv/lib/python3.10/site-packages/requests/models.py:978:json
2024-11-03 00:00:19.691	
/opt/venv/lib/python3.10/site-packages/socs/agents/ucsc_radiometer/agent.py:83:acq
2024-11-03 00:00:19.691	
/opt/venv/lib/python3.10/site-packages/ocs/ocs_agent.py:984:_running_wrapper
2024-11-03 00:00:19.691	
/opt/venv/lib/python3.10/site-packages/twisted/python/context.py:82:callWithContext
2024-11-03 00:00:19.691	
/opt/venv/lib/python3.10/site-packages/twisted/python/context.py:117:callWithContext
2024-11-03 00:00:19.691	
/opt/venv/lib/python3.10/site-packages/twisted/python/threadpool.py:285:<lambda>
2024-11-03 00:00:19.691	
/opt/venv/lib/python3.10/site-packages/twisted/python/threadpool.py:269:inContext
2024-11-03 00:00:19.691	
--- <exception caught here> ---
2024-11-03 00:00:19.691	
/opt/venv/lib/python3.10/site-packages/twisted/_threads/_team.py:192:doWork
2024-11-03 00:00:19.691	
/opt/venv/lib/python3.10/site-packages/twisted/_threads/_threadworker.py:49:work
2024-11-03 00:00:19.691	
/usr/lib/python3.10/threading.py:953:run
2024-11-03 00:00:19.691	
/usr/lib/python3.10/threading.py:1016:_bootstrap_inner
2024-11-03 00:00:19.691	
2024-11-03T00:00:19+0000 acq:0 CRASH: [Failure instance: Traceback: <class 'requests.exceptions.JSONDecodeError'>: Expecting value: line 1 column 9 (char 8)

EDIT: socs image tag: v0.5.1-22-g7d2f158-dev

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at socs/agents/ucsc_radiometer/agent.py:83, where the traceback enters the acquisition path, and inspect the response being passed through requests JSON decoding. Reproduce the failure using the reported Radiometer status and socs image tag v0.5.1-22-g7d2f158-dev. Done means the cause of the invalid JSON response is identified and the acquisition no longer crashes on this condition.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.