Possible bug reacquiring lock in 372 agent
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 17
- Forks
- 20
- Avg merge
- 1h 22m
- Merged PRs (30d)
- 2
Description
I was just looking through the 372 agent usage of release_and_acquire and I'm confused by this behavior:
https://github.com/simonsobs/socs/blob/4c8224e2289c79ac64bb9bc0b421dbb1a4263788/agents/lakeshore372/LS372_agent.py#L202-L205
This continue seems a bit sketchy as on the next iteration of the loop it'll try to release_and_acquire a second time, but having never actually re-acquired the lock...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at agents/lakeshore372/LS372_agent.py lines 202-205 and trace release_and_acquire through the surrounding loop. Inspect the lock state across continue and subsequent iterations; done means the agent does not attempt a second release_and_acquire without having successfully reacquired the lock.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100