simonsobs / simonsobs/socs

SupRsync does not update md5sum

Open
#475 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

agent: suprsync enhancement
Dominant language
Python
Stars
17
Forks
20
Avg merge
1h 22m
Merged PRs (30d)
2

Description

Thing I've found while testing on the E2E system that we've been avoiding running into because pysmurf-monitor doesn't add files to the database until they're complete.

After a file is added to the database, suprsync never updates the md5sum values of either the local or the remote files. This means that it never notices it needs to re-copy the file or (worse) if a file is added to the database at time A, copied after it changes at time B, it never realized the file is done copying.

I'm not prioritizing fixing this at the moment because I only noticed it trying to catch some edge cases in the finalization. But this does mean we are depending on pysmurf-monitor's behavior never changing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the SupRsync implementation and its md5sum handling, then trace the E2E sequence where a database record exists before the file is complete. Reproduce the update-after-insertion case and verify that changed local or remote files are detected, recopied when needed, and marked complete only after copying finishes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.