simonsobs / simonsobs/socs

pysmurf-controller operation method signature overrides missing args

Open
#460 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

documentation
Dominant language
Python
Stars
17
Forks
20
Avg merge
1h 22m
Merged PRs (30d)
2

Description

The pysmurf-controller's task and process method signature overrides aren't in sync with the actual args/kwargs they take. For instance:

stream(duration=None)

should be:

stream(duration=None, kwargs=None, load_tune=None, stream_type=None, subtype=None, tag=None)

Arguments that are optional should also be marked as such, notably kwargs and load_tune in this example, which don't say 'optional' next to their type.

https://socs.readthedocs.io/en/main/agents/pysmurf-controller.html#socs.agents.pysmurf_controller.agent.PysmurfController.stream

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the PysmurfController operation entries in the linked pysmurf-controller API documentation, beginning with stream. Compare each documented task and process signature with the actual arguments and mark optional arguments consistently; done means the documented signatures and optional-argument annotations match the implementation across the agent.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.