simonsobs / simonsobs/socs

Add "get_X" and "get_state" functions to LS372 agent

Open
#259 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

agent: ls372 enhancement
Dominant language
Python
Stars
17
Forks
20
Avg merge
1h 22m
Merged PRs (30d)
2

Description

Currently there are only a few tasks exposed for polling the current lakeshore settings:

  • get_dwell
  • get_excitation
  • get_resistance_range
  • get_still_output
    The other tasks are for setting things only i.e. set_active_channel, set_heater_range, set_pid, set_output_mode and don't have equivalent get functions. It would be very helpful to be able to poll the current state of the lakeshore by either having equivalent get_X functions for all set_X functions and/or a get_state function that returns a dictionary or similar output with all of the current settings to be able to tell what state you are in when walking up to the system blind.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the LS372 agent by reading the existing get_dwell, get_excitation, get_resistance_range, and get_still_output tasks alongside the set_* tasks. Decide whether equivalent getters or a single get_state result best fits the existing interface; done means all relevant Lakeshore settings can be polled reliably.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, embedded-iot
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.