simonsobs / simonsobs/ocs-web

PysmurfController: uxm_setup needs better (default) params

Open
#99 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Vue
Stars
3
Forks
1
PR merge metrics
No merged PRs in 30d

Description

The Agent prefers to pass things through untouched, so enforcing better defaults in ocs-web is ok.

Ref to sodetlib: https://github.com/simonsobs/sodetlib/blob/a9d7c559f479ba20d7abc29167e177580499245c/sodetlib/operations/uxm_setup.py#L739

Requested change is to force modify_attens=False.

Likely requires this to be fixed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced sodetlib uxm_setup implementation and inspect the ocs-web PysmurfController path that passes its parameters. Read the linked socs issue #1098 for the dependency and confirm how the default is currently handled. Done means the request forces modify_attens=False without changing other parameters.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.