simonsobs / simonsobs/mnms

crash for dg=0

Open
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
3
Forks
1
Avg merge
1m
Merged PRs (30d)
1

Description

Reminder for future us: in noise_models.py: downgrade //= post_filt_rel_downgrade on line 1414 will cause downgrade to become 0 when downgrade=1 and post_filt_rel_downgrade=2. This will cause a crash when the actual downgrading function is called.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in noise_models.py at line 1414 and inspect how downgrade is calculated when downgrade=1 and post_filt_rel_downgrade=2. Trace the resulting value into the actual downgrading function; done means the dg=0 case no longer causes a crash.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.