okmap becomes complex128 after concurrent_op because of phase dtype (complex128 by default). I think this fixes it.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3
- Forks
- 1
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
See https://github.com/simonsobs/mnms/pull/15
Karen found a similar issue which went away after reverting to numpy 1.26 from numpy 2. numpy 2 does say it changes how dtypes are silently cast in the case of math involving different dtypes, so I need to track down the exact operation(s) where this is happening
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading pull request #15 and reproducing the dtype change where okmap becomes complex128 after concurrent_op. Compare the relevant behavior between NumPy 1.26 and NumPy 2, then identify the exact operation or operations responsible; done means the casting cause and a validated fix are documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100