simonsobs / simonsobs/bb-awg-scripts

Filtering doesn't work with just `sim_ids` in yaml

Open
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
2
Forks
3
PR merge metrics
No merged PRs in 30d

Description

@earosenberg spotted that if you don't pass sim_ids to pipeline/filtering/filter_sims_sotodlib.py the code will fail, even if you passed sim_ids through the yaml.

We should decide whether to not accept sim_ids via the yaml at all, or if we reactivate it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with pipeline/filtering/filter_sims_sotodlib.py and trace how sim_ids is read from command-line arguments and the YAML configuration. Clarify whether YAML support should be removed or restored with the maintainer; the issue is done when the chosen behavior no longer fails when sim_ids is supplied through YAML.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.