simonsobs / simonsobs/SOOPERCOOL
Merge sim cells scripts
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 6
- Forks
- 5
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 2
Description
I need to look into it more carefully, but I think this could safely be merged with the other script to compute pseudo cells from simulations as sign-flip (or equivalently noise sims) are a required ingredients for the second script - we just need to allow signal to be None.
This PR is probably not the correct place to do it, I'll flag this as an issue for the future
Originally posted by @adrien-laposta in #78
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the two scripts that compute pseudo cells from simulations, including the sign-flip or noise-simulation path described in PR #78. Determine how their logic can be merged while allowing signal to be None; done when the combined scripts support both simulation workflows without changing their required behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100