simonsobs / simonsobs/PSpipe

Out of date CAMB

Open Beginner friendly
#212 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
15
Forks
12
PR merge metrics
No merged PRs in 30d

Description

When trying to run the ACT DR6 pipeline in /projects/ACT_DR6, I was met with the following error:

pspipe-run -p yaml/pipeline_dr6.yml
Traceback (most recent call last):
  File "/pscratch/sd/r/ricco/PSpipe/project/ACT_DR6/python/get_best_fit_mflike.py", line 43, in <module>
    l_th, ps_dict = pspy_utils.ps_from_params(cosmo_params, type, lmax + 500, **d["accuracy_params"])
                    ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/pscratch/sd/r/ricco/PSpipe/project/ACT_DR6/pyenv/dr6/lib/python3.13/site-packages/pspy/pspy_utils.py", line 77, in ps_from_params
    pars = camb.set_params(**camb_cosmo)
  File "/pscratch/sd/r/ricco/PSpipe/project/ACT_DR6/pyenv/dr6/lib/python3.13/site-packages/camb/camb.py", line 233, in set_params
    raise CAMBUnknownArgumentError(f"Unrecognized parameter: {k}")
camb.baseconfig.CAMBUnknownArgumentError: Unrecognized parameter: lens_margin
Traceback (most recent call last):
  File "/pscratch/sd/r/ricco/PSpipe/project/ACT_DR6/pyenv/dr6/bin/pspipe-run", line 6, in <module>
    sys.exit(main())
             ~~~~^^
  File "/pscratch/sd/r/ricco/PSpipe/pspipe/run.py", line 371, in main
    else subprocess.run(cmd, shell=True, check=True).returncode
         ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/global/common/software/nersc/pe/conda-envs/26.1.0/python-3.13/nersc-python/lib/python3.13/subprocess.py", line 577, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command 'python -u /pscratch/sd/r/ricco/PSpipe/project/ACT_DR6/python/get_best_fit_mflike.py  /pscratch/sd/r/ricco/PSpipe/project/ACT_DR6/products/dr6/global_dr6v4_bin50_updated.dict' returned non-zero exit status 1.

CAMB was recently updated to version 2.0.0 and takes lens_output_margin as the key instead of lens_margin. Updating the accuracy_params in global_dr6v4_bin50.dict fixed this issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the accuracy_params in global_dr6v4_bin50.dict and compare its CAMB parameter name with the installed CAMB 2.0.0 interface. Update the outdated key, then rerun pspipe-run -p yaml/pipeline_dr6.yml in /projects/ACT_DR6; done means the pipeline no longer raises CAMBUnknownArgumentError for lens_margin.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.