silverstripe / silverstripe/github-issue-search-client
Open or Closed Issues filter seems to be busted
Open
Nobody has claimed this yet.
type/bug
- Dominant language
- Vue
- Stars
- 6
- Forks
- 6
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 1
Description
If I search for "example", I currently get the following number of results:
- With "Open Issues": 489
- With "Closed Issues": 1167
- With "Open or Closed Issues": 9556
A pesky little undefined is making it into the query for "Open or Closed", where a is:closed or is:open would be otherwise. I'd expect the Open or Closed total to equal the Open + Closed totals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the "example" search and tracing how the Open or Closed Issues filter builds its query. Verify that the filter no longer includes undefined and that its result count equals the sum of the Open Issues and Closed Issues counts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, search
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100