silverstripe / silverstripe/github-issue-search-client
VUE_APP_GRAPHQL_TOKEN is still in client code
Open
Nobody has claimed this yet.
type/bug
- Dominant language
- Vue
- Stars
- 6
- Forks
- 6
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 1
Description
We've moved this to zeit.co so we can define the API token on the server, and proxy requests through this server implementation rather than straight to api.github.com. But we're still bundling VUE_APP_GRAPHQL_TOKEN into the app.js, which kinda defeats the purpose of hosting on zeit.co :) @robbieaverill
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating app.js and the server implementation that proxies requests to api.github.com. Trace how VUE_APP_GRAPHQL_TOKEN enters the client bundle and how GraphQL requests are routed. Done means the token is no longer bundled in app.js and requests use the server proxy instead.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, graphql
- Domain
- api, frontend, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100