sillsdev / sillsdev/silnlp

Check that config.py is setting the correct defaults for AlignmentEnhanced models.

Open
#124 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

invalid needs to be revisited
Dominant language
Python
Stars
39
Forks
7
Avg merge
1d 9h
Merged PRs (30d)
5

Description

Using silnlp.nmt.config to create AlignmentEnhanced models doesn't give the expected defaults.

When an SILTransformerBaseAlignmentEnhanced model is specified explicitly or used by the parent model then:
word_dropout should be set to 0
The coverage_penatly should be set to 0.1

We probably want the terms: dictionary: setting set to true.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in config.py and trace silnlp.nmt.config when an SILTransformerBaseAlignmentEnhanced model is explicit or inherited. Verify the resulting defaults for word_dropout, coverage_penalty, and the dictionary setting, then confirm both model-creation paths produce the requested values.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.