sillsdev / sillsdev/serval

Containers run as root; secrets mounted under /root

Open
#984 0 comments 0 reactions 1 assignee View on GitHub

@pmachapman is already working on this.

Since Aug 19, 2026.

Dominant language
C#
Stars
3
Forks
2
Avg merge
3d 1h
Merged PRs (30d)
3

Description

dockerfile has no USER directive (runs as root); the k8s deployment (deploy/serval/templates/serval-api-deployment.yaml) sets no securityContext and mounts DataProtection keys at /root/.aspnet/DataProtection-Keys. A code-exec bug runs as root with direct access to the key material.

Fix: Add a non-root USER in the Dockerfile and a pod securityContext (runAsNonRoot: true, allowPrivilegeEscalation: false, readOnlyRootFilesystem where feasible, drop capabilities). Relocate the DataProtection-Keys mount out of /root.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.