Defense-in-depth.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3
- Forks
- 2
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 3
Description
Defense-in-depth. SharedFileUtils.Normalize (src/Machine/src/Serval.Machine.Shared/Utils/SharedFileUtils.cs:5-19) doesn't strip ..; not currently reachable with user input (all callers use server-generated ids) but worth a guard. The langtags.json cache write (LanguageTagParser.cs:42) is not atomic (FileMode.Create directly to the cache path) and can poison the cache if the process dies mid-download.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Machine/src/Serval.Machine.Shared/Utils/SharedFileUtils.cs:5-19 and inspect LanguageTagParser.cs:42. Confirm how Normalize handles parent-directory segments and how the langtags.json cache is written. Done means the path input is guarded and an interrupted cache download cannot leave a partial cache at the target path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100