sillsdev / sillsdev/serval

Missing length/format validation

Open
#977 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
3
Forks
2
Avg merge
3d 1h
Merged PRs (30d)
3

Description

Missing length/format validation on free-text DTO fields (engine Name, languages, unbounded TextIds/filter lists) in CreateEngine.cs, CreateWebhook.cs, CreateDataFile.cs, StartBuild.cs. Add [StringLength]/[MaxLength] and collection caps (also reduces the C2/M3 surface; [ApiController] auto-validates DataAnnotations).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the DTO fields in CreateEngine.cs, CreateWebhook.cs, CreateDataFile.cs, and StartBuild.cs, focusing on free-text fields, languages, TextIds, and filter lists. Add the requested length, format, and collection limits, then verify that the API's automatic DataAnnotations validation rejects values exceeding those limits.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api, backend, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.