sillsdev / sillsdev/serval

SMT word graphs fail at over 200 words

Open
#373 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
3
Forks
2
Avg merge
3d 1h
Merged PRs (30d)
3

Description

Here is the error from the log:
Error: the sentence to translate is too long (MAX= 201 words)

It originates from https://github.com/sillsdev/thot/blob/b5f12b5d219c0fa359569f99b366972cbcb0cac9/src/stack_dec/_stackDecoder.h#L651C2-L652C30

Is this ok? I would assume we should do as much as we can instead of just failing - crop the words. Also, the error code as it trickles up is not clear - I didn't know where it was from or any other data. If it bubbled up to C# somehow, we could connect it with a specific job and text, etc.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/stack_dec/_stackDecoder.h around lines 651–652 and trace how the “MAX=201 words” error travels into the C# service. Clarify whether oversized sentences should be cropped or rejected, then define what context—such as the job and text—must be included when the error reaches the API.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, csharp
Domain
api, backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.