sillsdev / sillsdev/serval

Remove deprecated `PretranslationDto.Refs`

Open Beginner friendly
#1,017 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
3
Forks
2
Avg merge
3d 1h
Merged PRs (30d)
3

Description

Since we've moved to explicitly presenting the source and target refs and I believe SF is using the new properties, we should remove the generic Refs property.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the PretranslationDto definition and search for all uses of its Refs property. Check that consumers use the explicit source and target ref properties, then remove Refs and run the relevant existing test suite. Done means no remaining required use of the deprecated property and the API tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.