sillsdev / sillsdev/ptx2pdf

The (c) ... button dialog acted weird

Open
#985 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Fixed?
Dominant language
Python
Stars
33
Forks
15
PR merge metrics
No merged PRs in 30d

Description

I tried to set up the (c) David C. Cook text for one of the DCC pictures in the project using the (c) ... button. In that dialog window, I specified the text and location of the notification, and then I selected the option to propagate this to all pictures in the series.

I got this error message:


Mailto: ptxprint_support@sil.org

Traceback (most recent call last):
File "ptxprint\gtkview.py", line 5133, in onOverlayCreditClicked
AttributeError: 'Piclist' object has no attribute 'values'

PTXprint Version 2.6.5

I closed the error message.
Then

  • I tried to click OK at the copyright dialog, nothing happened.
  • I tried to click Cancel at the copyright dialog, nothing happened.
  • I clicked on the X button, and it finally closed the dialog.

When I exported the PDF. PTXprint did place the (c) David C. Cook text on the picture I was working on, but it did NOT propagate this request to all the other DCC pictures in the project.

After exporting the PDF, I returned to PTXprint to add another (c) David C. Cook text to another picture (mostly to see if things were still working or not). It's now worse. The dialog won't open and I get this error message:

Mailto: ptxprint_support@sil.org

Traceback (most recent call last):
File "ptxprint\gtkutils.py", line 66, in setWidgetVal
File "ptxprint\gtkutils.py", line 55, in _setcomboval
TypeError: 'NoneType' object is not iterable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "ptxprint\gtkview.py", line 5120, in onOverlayCreditClicked
File "ptxprint\gtkview.py", line 1412, in set
File "ptxprint\gtkutils.py", line 103, in setWidgetVal
TypeError: Setting <Gtk.ComboBoxText object at 0x0000015ad6fbd980 (GtkComboBoxText at 0x0000015a91dd8230)>, 'NoneType' object is not iterable

PTXprint Version 2.6.5

I closed and reopening PTXprint and tried the (c) dialog again.
If I just do ONE picture at a time, all functions okay.
But when I try to "Apply to ALL images in this series" I get the same error message as the first one.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in ptxprint/gtkview.py at onOverlayCreditClicked around lines 5120 and 5133, then inspect ptxprint/gtkutils.py setWidgetVal and _setcomboval around lines 55-103. Reproduce the copyright dialog with one picture and with “Apply to ALL images in this series.” Done means both dialog buttons work, the dialog can be reopened, and the credit propagates to every picture in the series without either traceback.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.