sillsdev / sillsdev/ptx2pdf

ChapterRangeSeparator doesn't get used in headers

Open
#955 1 comment 0 reactions 1 assignee View on GitHub

@markpenny is already working on this.

Since Aug 13, 2024.

enhancement Python
Dominant language
Python
Stars
33
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Currently we only use the VerseSeparator in the headers. Given that there are 2 different fields in the PT settings, we should probably make use of both depending on the context.

image (13)

One (simple) implementation (only on the Python side) is to say IF the user doesn't ask for verse numbers in the header, then use the Chapter Separator instead of the Verse separator defined by Paratext settings.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.