sillsdev / sillsdev/ptx2pdf

Filter glossary should pull in chained glossary entries.

Open
#633 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement Python
Dominant language
Python
Stars
33
Forks
15
PR merge metrics
No merged PRs in 30d

Description

When 'filter glossary...' is selected, and there are glossary entries that refers to other entries (e.g. \k Abram\k* see \w Abraham\w*) then the glossary can become incomplete unless both words are included in the biblical text.

The code should ideally build a list of not-seen-yet \w ....\w* entries and add the new entries (or repeat the filtering process) until there are no more changes.

In case anyone else is suffering this problem, putting the \w inside a \rem seems to be a work-around at the moment (don't forget to end the \rem with a printable paragraph style!):

\rem Glossary should also include \w Abraham\w*
\p
\v 27 Now these are the generations of Terah: Terah begat \w Abram\w*, Nahor, and
Haran; and Haran begat \w Lot\w*.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the glossary-filtering entry point and reproduce the issue with the supplied Abram-to-Abraham example. Trace how \w entries are collected, then verify that chained references are included until no new entries remain; the workaround in the issue provides a comparison case.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.