sillsdev / sillsdev/machine

Add support for versification conversion to ScriptureRangeParser

Open
#470 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
29
Forks
17
Avg merge
3d 2h
Merged PRs (30d)
8

Description

Follow on from https://github.com/sillsdev/serval/issues/1013.

As Serval expects Scripture Ranges in the target versification, and Scripture Forge inputs source corpus versifications for inferencing in the source versification (as SF cannot use the versification in the JavaScript frontend, so just lists what books the source has for inferencing), we need to be able to convert a ranges such as:

  • MAL1-4 (ENG) to MAL1-3 (ORG)
  • PSA1-151 (LXX/RSO) to PSA1-150,PS2 (ENG/ORG)
  • DAG1-12 (LXX) to DAN1-12 (ENG/ORG)
  • DAG13 (ENG/RSO) to SUS1 (ORG/LXX)
  • DAG14 (ENG/RSO) to BEL1 (ORG/LXX)

(These mappings are all present in the versification files)

As an actual bug SF is encountering, this only really affects drafting from Daniel or Psalms in LXX/Russian versification to English versification.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating ScriptureRangeParser and the versification files referenced in the issue, then inspect how ranges and book identifiers are currently parsed. Use the listed MAL, PSA, DAG, SUS, and BEL conversions as checks; done means source-versification ranges convert to the expected target-versification ranges, including split ranges and renamed books.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.