sillsdev / sillsdev/languageforge-lexbox
Make DraftProject.IsConfidential NonNullable
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 9
- Forks
- 8
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 49
Description
This is an issue for code debt that hasn't even been merged yet 😆.
DraftProject.IsConfidential sort of needs to be nullable initially, because we don't want existing drafts to just revert to the default when they're created/approved.
After:
- We've deployed #254
- Processed all the drafts that existed before that
We should be able to make DraftProject.IsConfidential NonNullable.
⚠️ Also look for any occurences of TODO #737's in the code base.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read issue #254 and locate DraftProject.IsConfidential and every TODO #737 occurrence in the codebase. Confirm that all pre-existing drafts have been processed after deployment, then make the property non-nullable and verify the affected draft creation and approval paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100