sillsdev / sillsdev/languageforge-lexbox
Minor improvement to BulkCreateEntries
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 9
- Forks
- 8
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 49
Description
Describe the feature
BulkCreateEntries currently calls logger.LogInformation("Added {Count} entries so far", entryCount) every 1000 entries, but doesn't log the total number of entries when it finishes. It's probably worth adding one more log entry at the very end of BulkCreateEntries (even after regenerating the entry search table): logger.LogInformation("Added {Count} entries", entryCount). That way the log will contain not just an every-1000-entries progress message, but also a note of precisely how many entries were added by the bulk operation. Which would be useful slightly more often than the current behavior, where a progress message is logged but the total number is not.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for the BulkCreateEntries entry point and read how it currently logs progress and completes the bulk operation. Add the final total-count log after the operation finishes, including after entry search table regeneration, and verify that the log reports the precise number of entries added.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100