sillsdev / sillsdev/languageforge-lexbox

"Missing X" filters only update in one direction

Open
#1,869 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

💻 FW Lite UI Design
Dominant language
C#
Stars
9
Forks
8
Avg merge
2d 13h
Merged PRs (30d)
49

Description

Describe the bug
When using the new filters feature for "Missing X", where X can be examples, senses, parts of speech, or semantic domains, the filter continues to show an entry as missing those things when those things are added to the entry. Turning the filter off and back on again correctly updates the list to not include the entry, but I would expect the list to update as soon as the missing item gets added.

I.e., if I'm filtering for "Missing semantic domains", the word "Apple" appears because the test project creates an Apple entry that has no semdom. If I add a semdom, I would expect the word "Apple" to disappear from the filtered list, but it doesn't. If I then turn off the "Missing semantic domains" toggle and turn it back on, then the word "Apple" disappears from the filtered list.

This does not happen in the reverse direction, where the thing (example, semdom, etc) was NOT missing and then gets deleted. If I have added a semdom to Apple and filtered for "Missing semantic domains", and then I delete the semdom(s) from Apple so that it now has no semantic domains, the word Apple appears immediately in the filtered list as soon as I click the "Submit" button on the semdom dialog.

To Reproduce
Steps to reproduce the behavior:

  1. Create a test project with just one entry, Apple
  2. Click on the filter icon
  3. Click "Missing Semantic Domains"
  4. See that Apple is in the filtered list because it has no semdom
  5. Add a semdom to the word Apple
  6. See that Apple is still in the filtered list
  7. Unselect and re-select "Missing Semantic Domains"
  8. See that Apple has disappeared from the filtered list

Expected behavior
The filtered list updates as soon as the missing item has been added, so that the word that now has a semantic domain is no longer on the "Missing Semantic Domains" list without needing to unselect and reselect the toggle.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from the filter icon using the "Missing Semantic Domains" filter, the Apple entry, and the semantic-domain dialog's Submit action. Trace the filter refresh after adding a semantic domain and compare it with the immediate update after deletion; done means the filtered list removes Apple immediately when the missing item is added.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.