sillsdev / sillsdev/languageforge-lexbox
Tidy up shadcn dialog
Open
Nobody has claimed this yet.
💻 FW Lite
- Dominant language
- C#
- Stars
- 9
- Forks
- 8
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 49
Description
TODO:
- scroll bar doesn't respect border-radius
- content behind the footer bleeds out the sides of the footer
- footer width feels awkward
Approximate approach:
- Introduce new Dialog.Body component.
- Dialog.Body takes over the scrolling responsibility from Dialog.Content.
- Dialog.Content gets overflow: hidden.
- Dialog.Footer can be in the body or content.
- In most dialogs add Dialog.Body as only child of Dialog.Content.
- In Entry/Sense Picker:
- Wrap everything except Dialog.Footer in Dialog.Body.
- Make footer full width
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the shadcn Dialog.Content, Dialog.Footer, Entry Picker, and Sense Picker usages. Check how scrolling, overflow, border-radius, and footer width currently behave, then verify that Dialog.Body handles scrolling and the footer no longer bleeds or feels narrow in the affected dialogs.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100