sillsdev / sillsdev/l10nsharp

Merge new strings with translations into "custom" localizations

Open
#84 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
3
Forks
10
Avg merge
4d 12h
Merged PRs (30d)
9

Description

Per the comment in both the TMX and XLIFF versions of FilenamesToAddToCache, we "Prefer the custom localizations folder version if it exists, otherwise the installed language folder." The problem with this is that a user might supply some missing translations, creating a custom localization. Even if they share those translations back to the developers and they are incorporated into a later version of the program, they'll continue to use their custom version, unless they are instructed to delete their local custom file so the program can use the "official" versions. That not only means that newly added or improved versions of strings for existing IDs will get ignored but -- even worse -- new translations for new string IDs will get ignored! I could not understand why I wasn't able to see the newly added translated strings for new string IDs until I stepped through the code and saw that comment.
This is probably fairly low exposure since very little field-based translation is probably happening for languages that have official translations. But it's pretty confusing and annoying when it does occur.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the custom-versus-installed localization selection described in the TMX and XLIFF versions of FilenamesToAddToCache. Determine how official updates should be combined with user-supplied entries; done should include updated existing strings and newly added string IDs without requiring users to delete their custom localization.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
localization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.