sillsdev / sillsdev/genericinstaller

Nothing checks that the pinned .NET 4.8 download URL still resolves

Open
#89 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6
Forks
4
PR merge metrics
No merged PRs in 30d

Description

BaseInstallerBuild/Bundle.wxs:46 pins the online bundle's .NET 4.8 payload to a single immutable CDN URL:

<?define NetFx48WebLink = https://download.visualstudio.microsoft.com/download/pr/2d6bb6b2-226a-4baa-bdec-798822606ff1/9b7b8746971ed51a1770ae4293618187/ndp48-web.exe ?>

674e62e chose this over go.microsoft.com/fwlink/?LinkId=2085155 so the bytes can never drift from the pinned Hash="4181398AA1FD5190155AC3A388434E5F7EA0B667" / Size="1439328". That is the right trade — but it leaves no fallback if Microsoft retires the path.

The ExePackage is Vital="yes", so a failed acquisition aborts the whole chain. If that URL stops resolving, every Online installer already in the field stops working, on machines that lack .NET 4.8.

Nothing would tell us. There is no CI in this repo, and the URL is only exercised on an end user's machine at install time.

Ask: a scheduled HEAD request against that URL, failing loudly. It turns a silent field outage into a notification, and the fix — repointing one ?define — is a one-line change we would otherwise make under pressure.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with BaseInstallerBuild/Bundle.wxs:46 and verify the pinned URL, hash, and size details. Add a scheduled HEAD check that fails loudly when the URL no longer resolves; done means the check runs on a schedule and reports an unavailable URL.

Written by the indexing model from the issue text.

Assessment

Domain
ci-cd, devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.