sillsdev / sillsdev/appbuilder-pwa
Inline styles in DAB may be using incorrect color variables
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 14
- Forks
- 39
- Avg merge
- 4h 50m
- Merged PRs (30d)
- 5
Description
Several DAB-specific components use inline styles to define background or text color using hardcoded CSS variables likeso:
<div style="color: var(--TabTextColor);">...
While this may be the correct color in most cases, it is still possible that a DAB user could choose to use a different theme color. This change would probably be represented in either the exported CSS from DAB or in the styles portion of the app config.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the DAB-specific components that define inline background or text colors, then inspect the exported DAB CSS and the app-config styles for theme color variables. Verify how a user-selected theme is represented and update the affected color references so alternate theme colors are honored; test with a non-default theme.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100